doc(example): fix the broken link.#2433
doc(example): fix the broken link.#2433google-oss-prow[bot] merged 2 commits intokubeflow:masterfrom
Conversation
google-oss-prow
bot
requested review from
andreyvelich,
anencore94 and
gaocegege
| must have the appropriate `PodDefault` with the `pipelines.kubeflow.org` audience. | ||
|
|
||
| Please follow [this guide](https://www.kubeflow.org/docs/components/pipelines/sdk/connect-api/#multi-user-mode) | ||
| Please follow [this guide](https://www.kubeflow.org/docs/components/pipelines/operator-guides/multi-user/) |
There was a problem hiding this comment.
@richardsliu @thesuperzapper @kubeflow/wg-pipeline-leads Should we use this guide to run KFP from Kubeflow Notebooks ?
https://www.kubeflow.org/docs/components/pipelines/user-guides/core-functions/connect-api/#serviceaccount-token-volume
There was a problem hiding this comment.
It seems that we have multiple authentication methods now. I've updated the link now :)
|
/rerun-all |
|
@Electronic-Waste You might need to re-push your commit since we can't re-trigger workflow which is more than one month old. |
Electronic-Waste
force-pushed
the
doc/broken-link-example
branch
from
3081deb to
8917a9d
Compare
|
@andreyvelich Done! It seems that CI is error and we need to wait for this PR to be ready: #2455 |
|
/rerun-all |
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Electronic-Waste
force-pushed
the
doc/broken-link-example
branch
from
8917a9d to
5d3b89d
Compare
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks @Electronic-Waste!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
What this PR does / why we need it:
As @yehudit1987 discussed with me in the Slack, there is a missing guide link in the environment setting section : https://github.com/kubeflow/katib/blob/master/examples/v1beta1/kubeflow-pipelines/README.md#multi-user-pipelines-setup
We decided to fix it to make the guide accessible to new-comers.
cc👀 @yehudit1987 @kubeflow/wg-automl-leads
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: